Add custom NitroEnclaveVerifier contract and update multiproof contracts#206
Open
roger-bai-coinbase wants to merge 5 commits intomainfrom
Open
Add custom NitroEnclaveVerifier contract and update multiproof contracts#206roger-bai-coinbase wants to merge 5 commits intomainfrom
roger-bai-coinbase wants to merge 5 commits intomainfrom
Conversation
- Add NitroEnclaveVerifier with ZK-based AWS Nitro attestation verification - Add tests for NitroEnclaveVerifier - Add proof submitter configurability to NitroEnclaveVerifier - Update TEEVerifier, MockVerifier, and deploy scripts accordingly - Update snapshots and semver-lock Made-with: Cursor
Collaborator
🟡 Heimdall Review Status
|
leopoldjoy
reviewed
Mar 12, 2026
leopoldjoy
reviewed
Mar 14, 2026
| import { Ownable } from "@solady/auth/Ownable.sol"; | ||
| import { EnumerableSet } from "@openzeppelin/contracts/utils/structs/EnumerableSet.sol"; | ||
| import { | ||
| INitroEnclaveVerifier, |
Contributor
There was a problem hiding this comment.
TEEProverRegistry and MockDevTEEProverRegistry still import INitroEnclaveVerifier / VerifierJournal / ZkCoProcessorType from the upstream lib, while this contract implements the custom interface. These are distinct Solidity types — we should probably update those contracts to use the custom interface.
| * - Only callable by contract owner | ||
| * - Address must not be zero | ||
| */ | ||
| function setProofSubmitter(address _proofSubmitter) external; |
Contributor
There was a problem hiding this comment.
Nit: setProofSubmitter is in the interface but the proofSubmitter() getter is not, so consumers using the interface type can set it but not read it. Let's also add function proofSubmitter() external view returns (address); to the query section?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made-with: Cursor